[Lldb-commits] [PATCH] D14085: Add Socket::Create factory method which uses socket scheme (tcp, unix, ..) to find an appropriate implementation class.
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Mon Oct 26 17:23:56 PDT 2015
zturner added a comment.
Do we need this `GetScheme()` method? And instead of having `Create` take a string, couldn't it just take a `SocketProtocol` instead? It seems like the logic of converting the string to the enum should be done in the `Acceptor` class, as this URI format is defined by the acceptor, and the socket itself is just a low-level host layer abstraction.
More information about the lldb-commits