[Lldb-commits] [lldb] r251269 - Corrects return values and typos in Arm watchpoint code

Omair Javaid via lldb-commits lldb-commits at lists.llvm.org
Sun Oct 25 16:18:35 PDT 2015


Author: omjavaid
Date: Sun Oct 25 18:18:35 2015
New Revision: 251269

URL: http://llvm.org/viewvc/llvm-project?rev=251269&view=rev
Log:
Corrects return values and typos in Arm watchpoint code

This is just a trivial patch that corrects a couple of return value account to function's return type.
Also corrects typo in hardware breakpoint handler.


Modified:
    lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp

Modified: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp?rev=251269&r1=251268&r2=251269&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp (original)
+++ lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp Sun Oct 25 18:18:35 2015
@@ -440,7 +440,7 @@ NativeRegisterContextLinux_arm::SetHardw
      if (bp_index == LLDB_INVALID_INDEX32)
          return LLDB_INVALID_INDEX32;
 
-    // Add new or update existing watchpoint
+    // Add new or update existing breakpoint
     if ((m_hbr_regs[bp_index].control & 1) == 0)
     {
         m_hbr_regs[bp_index].address = addr;
@@ -473,7 +473,7 @@ NativeRegisterContextLinux_arm::ClearHar
     error = ReadHardwareDebugInfo ();
 
     if (error.Fail())
-        return LLDB_INVALID_INDEX32;
+        return false;
 
     if (hw_idx >= m_max_hbp_supported)
         return false;
@@ -494,7 +494,7 @@ NativeRegisterContextLinux_arm::ClearHar
         WriteHardwareDebugRegs(eDREGTypeBREAK, hw_idx);
 
         if (error.Fail())
-            return LLDB_INVALID_INDEX32;
+            return false;
 
         return true;
     }
@@ -636,7 +636,7 @@ NativeRegisterContextLinux_arm::ClearHar
     error = ReadHardwareDebugInfo ();
 
     if (error.Fail())
-        return LLDB_INVALID_INDEX32;
+        return false;
 
     if (wp_index >= m_max_hwp_supported)
         return false;




More information about the lldb-commits mailing list