[Lldb-commits] [PATCH] D14023: Fix uses of range / xrange for Python 3

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Sat Oct 24 08:01:11 PDT 2015

tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.

> I've been putting most of this stuff in withouty review, but I figure every once in a while I should pass one your way as a sanity check to make sure I'm still on the right path.

That's fine.  As long as it isn't breaking anything, which so far it seems like hasn't :-)

> xrange() is removed from Python 3, and range() is no longer a function but a "sequence object" which must be converted to a list. In theory I could have used six.moves.xrange, but I decided that the efficiency provided by xrange wasn't important in the code, so I changed it all to use range instead.

Looks good!


More information about the lldb-commits mailing list