[Lldb-commits] [PATCH] D13964: Fix libstdc++ data formatters on Ubuntu 15.10 x86_64

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 22 02:04:35 PDT 2015

labath added a subscriber: labath.

Comment at: test/make/Makefile.rules:304
@@ -303,3 +303,3 @@
-			CXXFLAGS += -stdlib=libc++
+			CXXFLAGS += -stdlib=libc++ -DLLDB_USING_LIBCPP
 			LDFLAGS += -stdlib=libc++
Thanks for fixing the build.

When I get libc++ detection and skipping logic centralized, I'd like to remove this magic and make self.build() fail with a hard error in the case when the Makefile requests libc++ use, but the library is not present. The skipping logic should fire before self.build(), but it we still end up attempting to build, then that's something we should know about.

How does that sound?


More information about the lldb-commits mailing list