[Lldb-commits] [PATCH] D13964: Fix libstdc++ data formatters on Ubuntu 15.10 x86_64

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 21 16:29:23 PDT 2015


tfiala created this revision.
tfiala added a reviewer: granata.enrico.
tfiala added a subscriber: lldb-commits.

This change fixes data formatters for libstdc++ 6.0.21:

* Adds std::string data formatter support in C++ (rather than Python) for 6.0.21+.
* Uses std::list count field support when present.
* Fixes std container and std::string failing tests on Ubuntu 15.10 x86_64.
* Fixes what looks like a broken compilation on TOT which assumes libc++ is used but doesn't guarantee it, then uses libc++ details, which breaks when compiling with libstdc++.  (The test would later figure it out, but only after the failing build step).  Modified the using of libc++ to define a LLDB_USING_LIBCPP flag when we're really compiling with it, and conditionally compile the libc++-specific code so it doesn't break when  built with libstdc++.

Anybody on the Linux/BSD side, feel free to review.

This has been tested on Ubuntu 14.04 x86_64 (with libstdc++ 6.0.20) and Ubuntu 15.10 x86_64 (with libstdc++ 6.0.21).  Both built using clang-3.6 and using clang-3.6 inferiors.

http://reviews.llvm.org/D13964

Files:
  examples/synthetic/gnu_libstdcpp.py
  source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
  source/Plugins/Language/CPlusPlus/LibStdcpp.cpp
  source/Plugins/Language/CPlusPlus/LibStdcpp.h
  test/functionalities/data-formatter/data-formatter-stl/libcxx/list/loop/main.cpp
  test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/TestDataFormatterStdString.py
  test/make/Makefile.rules

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13964.38063.patch
Type: text/x-patch
Size: 20196 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151021/90f4d5b9/attachment-0001.bin>


More information about the lldb-commits mailing list