[Lldb-commits] [PATCH] D13881: Add domain socket support to gdb-remote protocol and lldb-server.

[Pavel Labath via lldb-commits]

labath accepted this revision.
labath added a comment.

looks good, thanks.


================
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:151
@@ +150,3 @@
+    char message[PATH_MAX];
+    snprintf (message, sizeof (message), "forward:tcp:%d;localfilesystem:%s", local_port, remote_socket_name);
+
----------------
ovyalov wrote:
> I suspect adb fails in such situation.
> Let me verify it once lldb-server/Acceptor will support protocol-based URL like unix:///tmp/platform.sock. Now it's somewhat problematic because we cannot pass colon as a part of
> URL - if colon is found it's treated as $host:$port pattern and TCPSocket is created.
Ok, makes sense.


http://reviews.llvm.org/D13881