[Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.
Eugene Zelenko via lldb-commits
lldb-commits at lists.llvm.org
Tue Oct 20 11:16:31 PDT 2015
Eugene.Zelenko added a comment.
Did you format code with Clang-format? Spaces/no spaces between function names and arguments are inconsistent.
================
Comment at: source/Plugins/Language/Go/GoFormatterFunctions.h:29
@@ +28,3 @@
+
+#include "clang/AST/ASTContext.h"
+
----------------
This header belongs to Other libraries and framework includes.
================
Comment at: source/Plugins/Language/Go/GoLanguage.cpp:25
@@ +24,3 @@
+
+#include <functional>
+#include <mutex>
----------------
This and next include belong to C++ Includes.
Repository:
rL LLVM
http://reviews.llvm.org/D13878
More information about the lldb-commits
mailing list