[Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

Eugene Zelenko via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 20 10:59:47 PDT 2015


Eugene.Zelenko added inline comments.

================
Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:10
@@ +9,3 @@
+
+#include <vector>
+
----------------
ribrdb wrote:
> Eugene.Zelenko wrote:
> > Please add include section comments. Same for other sections.
> Which sections? I've seen a couple types of section markers in different files, but it's not consistent. Are there documented recommendations for these?
See source/Plugins/Language/Go/GoLanguage.h below. At least this style is consistent across LLDB headers.


Repository:
  rL LLVM

http://reviews.llvm.org/D13878





More information about the lldb-commits mailing list