[Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

Tamas Berghammer via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 20 03:22:49 PDT 2015

tberghammer added a comment.

Looks good with a few minor comments inline

One additional design question:
What is your opinion about specifying the default value for the memory cache line size (the 512 byte) in Platform::GetDefaultMemoryCacheLineSize() instead of in the property definition? I think it makes the interface a bit cleaner and then target.process.memory-cache-line-size can have a default value of 0 (or -1) on LLDB startup and we overwrite it by the value returned by the Platform if it haven't been set to an actual value by the user.

Comment at: test/android/platform/TestDefaultCacheLineSize.py:15-17
@@ +14,5 @@
+    def setUp(self):
+        # Call super's setUp().
+        TestBase.setUp(self)
(nit): You don't need this (called automatically because of the inheritance)

Comment at: test/android/platform/TestDefaultCacheLineSize.py:37
@@ +36,3 @@
+        # We have successfully caught thread creation. Now just run to completion
+        process.Continue()
(nit): I think it is a leftover from an other test


More information about the lldb-commits mailing list