[Lldb-commits] [lldb] r250673 - Python: follow python guidelines for header usage

Saleem Abdulrasool via lldb-commits lldb-commits at lists.llvm.org
Sun Oct 18 18:16:17 PDT 2015

Author: compnerd
Date: Sun Oct 18 20:16:17 2015
New Revision: 250673

URL: http://llvm.org/viewvc/llvm-project?rev=250673&view=rev
Python: follow python guidelines for header usage

Python requires that Python.h is included before any std header.  Not doing so
results in conflicts with standards macros such as `_XOPEN_SOURCE`.  NFC.


Modified: lldb/trunk/scripts/Python/modules/readline/readline.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/Python/modules/readline/readline.cpp?rev=250673&r1=250672&r2=250673&view=diff
--- lldb/trunk/scripts/Python/modules/readline/readline.cpp (original)
+++ lldb/trunk/scripts/Python/modules/readline/readline.cpp Sun Oct 18 20:16:17 2015
@@ -1,6 +1,10 @@
-#include <stdio.h>
+// NOTE: Since Python may define some pre-processor definitions which affect the
+// standard headers on some systems, you must include Python.h before any
+// standard headers are included.
 #include "Python.h"
+#include <stdio.h>
 #include <editline/readline.h>

More information about the lldb-commits mailing list