[Lldb-commits] [PATCH] D13754: Split Socket class into Tcp/Udp/DomainSocket subclasses.

[Oleksiy Vyalov via lldb-commits]

ovyalov added inline comments.

================
Comment at: source/Host/posix/DomainSocket.cpp:74
@@ +73,3 @@
+    FileSystem::Unlink(FileSpec{name, true});
+
+    Error error;
----------------
labath wrote:
> If we're going to use unique names, then this won't be necessary (and I would much rather see a random error opening a socket than a random file disappearing). BTW, have you considered using abstract sockets for the lldb-server use case? Albeit linux-specific, I find them much nicer, as they have no connection to the file system whatsoever.
I was thinking about using abstract sockets but didn't try them in runtime on Android - will check.



http://reviews.llvm.org/D13754