[Lldb-commits] [PATCH] D13727: Add task pool to LLDB

[Todd Fiala via lldb-commits]

tfiala added a comment.

I'm in agreement with Pavel's assessment on this.

Regarding the tests, I had brought that up with Greg earlier.  We can handle that in a few different ways:

- We do nothing, and perhaps some collections of tests run slower if they are all pounding on their thread pools at the same time with heavy CPU work.
- We add a "max cpu" setting to lldb and just have an option that flips it to something relatively low (enough to test the concurrent nature but not giving it too much CPU).  The test suite can then limit this.
- Add a ninja-like cpu monitor to the test runner for the non-pool test runners (and also get those running right on Windows), and only keep enough test workers running to keep the machine hot.  That would self adjust.  (I haven't thought about this at all so I don't yet have an idea of how hard it will be to do it in an all-platform-encompasing way, but I'm sure it's a solvable problem).

Just some thoughts....


http://reviews.llvm.org/D13727