[Lldb-commits] [PATCH] D13754: Split Socket class into Tcp/Udp/DomainSocket subclasses.

Oleksiy Vyalov via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 15 15:18:53 PDT 2015

ovyalov added inline comments.

Comment at: source/Host/common/Socket.cpp:356
@@ -740,3 +355,3 @@
-uint16_t Socket::GetLocalPortNumber(const NativeSocket& socket)
+size_t Socket::Send(const void *buf, const size_t num_bytes)
Good point - done.

Comment at: source/Host/posix/DomainSocket.cpp:73
@@ +72,3 @@
+    FileSystem::Unlink(FileSpec{name, true});
labath wrote:
> Not really in scope of this patch, but I must say I find blindly deleting a file like this dangerous.
If we're going to use unique file names per socket it shouldn't be too dangerous.


More information about the lldb-commits mailing list