[Lldb-commits] [PATCH] D13727: Add task pool to LLDB

[Tamas Berghammer via lldb-commits]

tberghammer updated this revision to Diff 37498.
tberghammer added a comment.

Addressing comments from the discussion with destroying the treads not in use while keeping a global thread pool with at most hardware_concurrency threads.

IMO this update also simplifies the implementation of the ThreadPool with removing the conditional_variable.

A possible future improvement is to destroy the threads only if they are idle for a given time (e.g. 50 ms) so we still don't have them hanging around while we can avoid the possibly unnecessary thread creation and destroyation in case the tasks coming in slowly.


http://reviews.llvm.org/D13727

Files:
  include/lldb/Utility/TaskPool.h
  source/Utility/CMakeLists.txt
  source/Utility/TaskPool.cpp
  unittests/Utility/CMakeLists.txt
  unittests/Utility/TaskPoolTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13727.37498.patch
Type: text/x-patch
Size: 11269 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151015/7bda1e65/attachment.bin>