[Lldb-commits] [PATCH] D13646: [LLDB] Don't use signo as key in Signals DenseMap, as signo are not unique

[Pavel Labath via lldb-commits]

labath added a comment.

This looks much better, I just have a couple of small remarks.


================
Comment at: include/lldb/Target/UnixSignals.h:116
@@ -114,1 +115,3 @@
+               const char *description,
+               const char *alias = NULL);
 
----------------
nullptr

================
Comment at: source/Plugins/Process/Utility/LinuxSignals.cpp:33
@@ +32,3 @@
+    AddSignal (5,    "SIGTRAP",       true ,   true , true , "trace trap (not reset when caught)");
+    AddSignal (6,    "SIGABRT",       false,   true , true , "abort()", "SIGIOT");
+    AddSignal (7,    "SIGBUS",        false,   true , true , "bus error");
----------------
It would be great to align these, so they don't get lost in the noise.

================
Comment at: source/Plugins/Process/Utility/MipsLinuxSignals.cpp:33
@@ +32,3 @@
+    AddSignal (5,    "SIGTRAP",      true ,   true , true , "trace trap (not reset when caught)");
+    AddSignal (6,    "SIGIOT",       false,   true , true , "IOT trap", "SIGABRT");
+    AddSignal (7,    "SIGEMT",       false,   true , true , "terminate process with core dump");
----------------
In LinuxSignals SIGABRT was the main name, while SIGIOT was an alias. Is this intentional? (as in, this signal is usually referred to as SIGIOT on mips platforms). If not, could you make it consistent?


Repository:
  rL LLVM

http://reviews.llvm.org/D13646