[Lldb-commits] [PATCH] D13754: Split Socket class into Tcp/Udp/DomainSocket subclasses.

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 14 16:51:53 PDT 2015

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Can we change "TcpSocket" to be "TCPSocket" and "UdpSocket" to be "UDPSocket" in all code and in the file names? Other than that it looks good.

Comment at: source/Host/common/Socket.cpp:403
@@ +402,3 @@
+        socketType |= SOCK_CLOEXEC;
+  #endif
+    auto sock = ::socket (domain, socketType, protocol);
indent wrong


More information about the lldb-commits mailing list