[Lldb-commits] [PATCH] D13657: [lldb] char summary provider

[Eugene Leviant via lldb-commits]

evgeny777 added inline comments.

================
Comment at: source/API/SBTypeSummary.cpp:157
@@ +156,3 @@
+                            SBStream stream;
+                            if (!cb(valobj.GetSP(), &opt, stream))
+                                return false;
----------------
granata.enrico wrote:
> evgeny777 wrote:
> > granata.enrico wrote:
> > > I assume you are essentially relying on the SBValue constructor that takes a ValueObjectSP here, right?
> > > And similarly for the SummaryOptions?
> > You're right - implicit construction here
> Sorry to nitpick, but is there any advantage to not using explicit construction here?
None, except more compact code. Would like to use explicit construction here?


http://reviews.llvm.org/D13657