[Lldb-commits] [PATCH] D13657: [lldb] char summary provider

[Enrico Granata via lldb-commits]

granata.enrico added a comment.

Admittedly way simpler than my original idea. +1

Having the RTTI support so that these SBTypeSummary objects can actually be used for anything other than mere creation would be nice.
However, I can fill that gap myself later.


================
Comment at: source/API/SBTypeSummary.cpp:157
@@ +156,3 @@
+                            SBStream stream;
+                            if (!cb(valobj.GetSP(), &opt, stream))
+                                return false;
----------------
I assume you are essentially relying on the SBValue constructor that takes a ValueObjectSP here, right?
And similarly for the SummaryOptions?

================
Comment at: source/API/SBTypeSummary.cpp:162
@@ +161,3 @@
+                       },
+                       "SBTypeSummary formatter callbacxk"
+                   )
----------------
Any reason not to let people submit their own name/description for the summary formatter here?


http://reviews.llvm.org/D13657