[Lldb-commits] [PATCH] D13695: lldb-server: add support for binary memory reads

[Pavel Labath via lldb-commits]

labath updated this revision to Diff 37340.
labath added a comment.

The new functionality gets picked up by the client and automatically used everywhere, so I'm not
really worried about testing it. A more important issue would be making sure that the legacy read
packet does not rot as it is now unused. I have added a test which makes sure both packets return
the same value (modulo hex-encoding), which should prevent that.


http://reviews.llvm.org/D13695

Files:
  examples/python/read_test.py
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Utility/StringExtractorGDBRemote.cpp
  source/Utility/StringExtractorGDBRemote.h
  test/functionalities/archives/a.dwo
  test/functionalities/archives/b.dwo
  test/lang/cpp/incomplete-types/length_limit.dwo
  test/lang/cpp/incomplete-types/length_nolimit.dwo
  test/lang/go/goroutines/a.out
  test/lang/go/types/a.out
  test/tools/lldb-server/TestGDBRemoteMemoryRead.py
  test/types/recursive_type_1.d
  test/types/recursive_type_1.dwo
  test/types/recursive_type_1.o

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13695.37340.patch
Type: text/x-patch
Size: 10488 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151014/4b5ea270/attachment.bin>