[Lldb-commits] [PATCH] D13699: RenderScript command for printing allocation contents.

[Pavel Labath via lldb-commits]

labath added a subscriber: labath.
labath added a comment.

Hi Ewan,

this commit introduces a new warning:

  lldb/source/Commands/CommandObjectMemory.cpp:1502:21: warning: enumeration value 'eFormatVectorOfFloat16' not handled in switch [-Wswitch]
              switch (m_format_options.GetFormat())

Also, it breaks TestDataFormatterSmartArray.py.

    File "/lldb-buildbot/lldbSlave/buildWorkingDir/llvm/tools/lldb/test/functionalities/data-formatter/data-formatter-smart-array/TestDataFormatterSmartArray.py", line 19, in test_with_run_command
      self.data_formatter_commands()
    File "/lldb-buildbot/lldbSlave/buildWorkingDir/llvm/tools/lldb/test/functionalities/data-formatter/data-formatter-smart-array/TestDataFormatterSmartArray.py", line 279, in data_formatter_commands
      '{78.5},{77.25},{78},{76.125},{76.75},{76.875},{77}'])
    File "/lldb-buildbot/lldbSlave/buildWorkingDir/llvm/tools/lldb/test/lldbtest.py", line 2794, in expect
      msg if msg else EXP_MSG(str, exe))
  AssertionError: False is not True : '{78.5},{77.25},{78},{76.125},{76.75},{76.875},{77}' returns expected result

Could you look into these issues? If you can't look into it now, shall we revert it until you get a chance to have a look?


Repository:
  rL LLVM

http://reviews.llvm.org/D13699