[Lldb-commits] [PATCH] D13652: Change ConstString to support massive multi-threaded access
Tamas Berghammer via lldb-commits
lldb-commits at lists.llvm.org
Tue Oct 13 08:54:21 PDT 2015
tberghammer updated this revision to Diff 37258.
tberghammer added a comment.
Use llvm::sys::RWMutex
Using it have a minor performance hit for debug info parsing because of the intensive write operations, but should have a positive impact on all reads (most access after debug info parsing). If the performance hit for writes isn't acceptable we can add a flag to the ConstString constructor hinting that we are creating a new string so we don't have to make a check in this case, but I prefer to don't do it until we can prove it is necessary.
http://reviews.llvm.org/D13652
Files:
source/Core/ConstString.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13652.37258.patch
Type: text/x-patch
Size: 6678 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151013/2c9220e5/attachment.bin>
More information about the lldb-commits
mailing list