[Lldb-commits] [PATCH] D12250: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in source/Plugins, unify closing inclusion guards and code layout

Bruce Mitchener via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 7 18:50:16 PDT 2015


brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.

There are a number of places where you've changed spaces to tabs ... Also the GetShortPluginName has already been removed. Please rebase forward and correct the whitespace issues.


================
Comment at: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h:100
@@ -107,1 +99,3 @@
+		    uint32_t reg_num, 
+		    lldb_private::RegisterInfo &reg_info) override;
 
----------------
This looks like a whitespace error. Why introduce tabs here?


Repository:
  rL LLVM

http://reviews.llvm.org/D12250





More information about the lldb-commits mailing list