[Lldb-commits] [PATCH] D13537: Port native Python API to support 3.x

[Greg Clayton via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Few minor changes.


================
Comment at: source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1183
@@ +1182,3 @@
+            llvm::StringRef value_str(str.GetString());
+            error.SetErrorStringWithFormat("%s\n%s", value_str.data(), bt.c_str());
+        }
----------------
"value_str.data()" might not be NULL terminate. Either use value_str.str().c_str() or use "%*s":

```
error.SetErrorStringWithFormat("%*s\n%s", (int)value_str.size(), value_str.data(), bt.c_str());
```

================
Comment at: unittests/ScriptInterpreter/CMakeLists.txt:4
@@ +3,1 @@
+endif()
\ No newline at end of file

----------------
add newline

================
Comment at: unittests/ScriptInterpreter/Python/CMakeLists.txt:6
@@ +5,1 @@
+  target_link_libraries(ScriptInterpreterPythonTests lldbPluginScriptInterpreterPython ${PYTHON_LIBRARY})
\ No newline at end of file

----------------
add newline


http://reviews.llvm.org/D13537