[Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

Kirill Lapshin via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 7 11:51:13 PDT 2015


KLapshin added a comment.

In http://reviews.llvm.org/D12968#261762, @labath wrote:

> I have committed http://reviews.llvm.org/D13056 with the event hijacking portion from your patch. I think your use case should be working now. I am planning to return to this later, as I believe there are still some edge cases lurking here.


Yes, of course - hijacked listener setup solves (or hides) issue.

Problem on my side (if no hijacking listener used and without your patch for race condition) is - halt listener often just got timeout (10 secs), then target process killed without crash. Or may work without timeout - this is really threads conflict issue - m_listener in process object unusable because operates with invalid data - I even saw strings in log belongs to RSP module - just random memory areas, memory corrupted. If you set hijacked listener - no problem because it looks has non-shared m_events collection.

Again - this is remote debugging issue only. Also I checked on Linux host debugging - process killed just fine.

I will try pure public lldb build with your patch and will see then, thanks.


Repository:
  rL LLVM

http://reviews.llvm.org/D12968





More information about the lldb-commits mailing list