[Lldb-commits] [lldb] r249477 - Modify minimumg go version to 1.4.0 for tests.

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 6 15:14:34 PDT 2015


Author: tfiala
Date: Tue Oct  6 17:14:33 2015
New Revision: 249477

URL: http://llvm.org/viewvc/llvm-project?rev=249477&view=rev
Log:
Modify minimumg go version to 1.4.0 for tests.

Modified:
    lldb/trunk/test/lldbtest.py

Modified: lldb/trunk/test/lldbtest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lldbtest.py?rev=249477&r1=249476&r2=249477&view=diff
==============================================================================
--- lldb/trunk/test/lldbtest.py (original)
+++ lldb/trunk/test/lldbtest.py Tue Oct  6 17:14:33 2015
@@ -939,10 +939,7 @@ def skipUnlessGoInstalled(func):
             self.skipTest("skipping because go compiler not found")
         else:
             # Ensure the version is the minimum version supported by
-            # the go tests.  Empirically this is *not* version go1.2.1
-            # that comes with Ubuntu 14.04.  Go maintainers should
-            # verify, or possibly extend this decorator to provide
-            # min go versions that can vary by test.
+            # the LLDB go support.
             match_version = re.search(r"(\d+\.\d+(\.\d+)?)", compiler)
             if not match_version:
                 # Couldn't determine version.
@@ -951,12 +948,12 @@ def skipUnlessGoInstalled(func):
                     "out of {}".format(compiler))
             else:
                 from distutils.version import StrictVersion
-                min_strict_version = StrictVersion("1.3.0")
+                min_strict_version = StrictVersion("1.4.0")
                 compiler_strict_version = StrictVersion(match_version.group(1))
                 if compiler_strict_version < min_strict_version:
                     self.skipTest(
                         "skipping because available go version ({}) does "
-                        "not meet minimum go version {}".format(
+                        "not meet minimum required go version ({})".format(
                             compiler_strict_version,
                             min_strict_version))
             func(*args, **kwargs)




More information about the lldb-commits mailing list