[Lldb-commits] [PATCH] D13404: Teach CMake to find versions of Python != 2.7
Vadim Macagon via lldb-commits
lldb-commits at lists.llvm.org
Mon Oct 5 21:35:35 PDT 2015
enlight added inline comments.
================
Comment at: cmake/modules/LLDBConfig.cmake:113
@@ +112,3 @@
+ set (PYTHON_LIBRARY ${PYTHON_LIBRARY} PARENT_SCOPE)
+ set (PYTHON_DLL ${PYTHON_LIBRARY} PYTHON_DLL PARENT_SCOPE)
+ set (PYTHON_INCLUDE_DIRS ${PYTHON_INCLUDE_DIRS} PARENT_SCOPE)
----------------
You missed :P
================
Comment at: cmake/modules/LLDBConfig.cmake:140
@@ -106,1 +139,3 @@
+
+ if (PYTHON_LIBRARY)
include_directories(${PYTHON_INCLUDE_DIRS})
----------------
Can we make this `if (PYTHON_INCLUDE_DIRS)` instead?
http://reviews.llvm.org/D13404
More information about the lldb-commits
mailing list