[Lldb-commits] [PATCH] D13404: Teach CMake to find versions of Python != 2.7

[Vadim Macagon via lldb-commits]

enlight added inline comments.

================
Comment at: cmake/modules/LLDBConfig.cmake:56
@@ +55,3 @@
+    message("LLDB embedded Python on Windows requires specifying a value for PYTHON_HOME.  Python support disabled.")
+    set(LLDB_DISABLE_PYTHON 1)
+    return()
----------------
This will only set `LLDB_DISABLE_PYTHON` inside the function, you probably want to do `set (LLDB_DISABLE_PYTHON 1 PARENT_SCOPE)`, or `set (LLDB_DISABLE_PYTHON 1 CACHE INTERNAL "")` instead.

================
Comment at: cmake/modules/LLDBConfig.cmake:73
@@ +72,3 @@
+    message("Python support will be disabled for this build.")
+    set(LLDB_DISABLE_PYTHON 1)
+    return()
----------------
Ditto.


http://reviews.llvm.org/D13404