[Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

[Eugene Leviant via lldb-commits]

evgeny777 added inline comments.

================
Comment at: include/lldb/API/SBTypeSummary.h:125
@@ +124,3 @@
+
+        bool DoesPrintValue(const lldb::SBValue &value) const;
+
----------------
granata.enrico wrote:
> Can you please change this to
> 
> bool
> DoesPrintValue (lldb::SBValue value);
> 
> There is no need to pass the SBValue by reference since you're not actually altering it - and since SBValue wraps a (glorified) pointer to a ValueObject you're not really copying much data over. I don't see the need to classify the function as const (only IsValid() seems to be marked thusly in that file), and definitely no need for the SBValue to be a const
Ok. 
Just curious - why const is bad?


http://reviews.llvm.org/D13058