[Lldb-commits] [lldb] r248998 - Trim the output of mktem in PlatformAndroid::DownloadSymbolFile

Tamas Berghammer via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 1 02:42:36 PDT 2015


Author: tberghammer
Date: Thu Oct  1 04:42:23 2015
New Revision: 248998

URL: http://llvm.org/viewvc/llvm-project?rev=248998&view=rev
Log:
Trim the output of mktem in PlatformAndroid::DownloadSymbolFile

Differential revision: http://reviews.llvm.org/D13293

Modified:
    lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp

Modified: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp?rev=248998&r1=248997&r2=248998&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp (original)
+++ lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp Thu Oct  1 04:42:23 2015
@@ -331,7 +331,7 @@ PlatformAndroid::DownloadSymbolFile (con
     Error error = adb.Shell("mktemp --directory --tmpdir /data/local/tmp", 5000 /* ms */, &tmpdir);
     if (error.Fail() || tmpdir.empty())
         return Error("Failed to generate temporary directory on the device (%s)", error.AsCString());
-    tmpdir.erase(tmpdir.size() - 1); // Remove trailing new line
+    tmpdir = llvm::StringRef(tmpdir).trim().str();
 
     // Create file remover for the temporary directory created on the device
     std::unique_ptr<std::string, std::function<void(std::string*)>> tmpdir_remover(




More information about the lldb-commits mailing list