[Lldb-commits] [PATCH] D13300: Run tests with dwo symbol files

[Pavel Labath via lldb-commits]

labath added a comment.

Only small comments from me.


================
Comment at: test/dotest_args.py:63
@@ -62,3 +62,3 @@
     group = parser.add_argument_group('Test filtering options')
-    group.add_argument('-N', choices=['dwarf', 'dsym'], help="Don't do test cases marked with the @dsym decorator by passing 'dsym' as the option arg, or don't do test cases marked with the @dwarf decorator by passing 'dwarf' as the option arg")
+    group.add_argument('-N', choices=['dwarf', 'dwo', 'dsym'], help="Don't do test cases marked with the @dsym decorator by passing 'dsym' as the option arg, or don't do test cases marked with the @dwarf decorator by passing 'dwarf' as the option arg")
     X('-a', "Don't do lldb Python API tests")
----------------
This help string sounds like it needs updating.

================
Comment at: test/functionalities/dead-strip/TestDeadStrip.py:16
@@ -15,2 +15,3 @@
     @expectedFailureWindows("llvm.org/pr24778")
+    @expectedFailureDwo # In case of a stripped symbol we put a breakpoint at 0x0 instead of reporting an error
     @skipIfFreeBSD # The -dead_strip linker option isn't supported on FreeBSD versions of ld.
----------------
Could you file a bug about this?


http://reviews.llvm.org/D13300