[Lldb-commits] [PATCH] D13291: Make the ArmUnwindInfo parsing code endian independent

[Pavel Labath via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good, after fixing some typos.


================
Comment at: include/lldb/Symbol/ArmUnwindInfo.h:55
@@ -46,1 +54,3 @@
+
+    const ObjectFile& m_objfile;
     lldb::SectionSP m_arm_exidx_sp; // .ARM.exidx section
----------------
For consideration:
storing just the byte order instead of the whole ObjectFile. (if it's clear that the ObjectFile object outlives this object then I'm fine with this also).

================
Comment at: source/Symbol/ArmUnwindInfo.cpp:58
@@ +57,3 @@
+// Read a byte from the unwind instruction stream with the given offset.
+// Custome function is required because have to red in order of significance within their containing
+// word (most significant byte first) and in increasing word address order.
----------------
s/Custome/Custom/
s/red/read/

================
Comment at: source/Symbol/ArmUnwindInfo.cpp:66
@@ -59,1 +65,3 @@
+        value = llvm::ByteSwap_32(value);
+    return (data[0] >> ((3 - (offset % 4)) * 8)) & 0xff;
 }
----------------
s/data[0]/value ?


http://reviews.llvm.org/D13291