[Lldb-commits] [PATCH] D13245: Add support for .ARM.exidx unwind information

[Tamas Berghammer via lldb-commits]

tberghammer marked an inline comment as done.

================
Comment at: source/Symbol/ArmUnwindInfo.cpp:62
@@ +61,3 @@
+static uint64_t
+GetULEB128(const uint32_t* data, uint16_t& offset, uint16_t max_offset)
+{
----------------
labath wrote:
> Is there a reason DataExtractor::GetULEB128 could not be reused?
DataExtractor is reading from a stream of bytes while the arm unwind info is encoded in a bit more complicated (and strange way). It is encoded as a list of 4 byte words and then the 1 byte values have to be read from it from the MSB byte to the LSB byte what isn't match with the order used by the DataExtractor.


http://reviews.llvm.org/D13245