[Lldb-commits] [PATCH] D13288: Restrict the scope of a hack in DYLDRendezvous

[Pavel Labath via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

looks good


================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:421
@@ +420,3 @@
+    uint32_t os_major = 0, os_minor = 0, os_update = 0;
+    if (arch.GetTriple().getEnvironment() == llvm::Triple::Android &&
+        m_process->GetTarget().GetPlatform()->GetOSVersion(os_major, os_minor, os_update) &&
----------------
This is condition is getting quite complicated. Consider putting it in a function (`bool isBaseAddressBuggy(string file)` perhaps?).


http://reviews.llvm.org/D13288