[Lldb-commits] [Diffusion] rL247746: Search variables based on clang::DeclContext and clang::Decl tree

[Siva Chandra via lldb-commits]

sivachandra added a subscriber: sivachandra.
sivachandra added a comment.

Calling this a regression is probably harsh. Without looking into it much, my feeling here is that Clang (the LLDB compiler) does not ask for the value ScNSpacGl in the global namespace, but just for a value named ScNSpacGl. In which case, LLDB (after this change), returns the most meaningful value for the context to Clang. Before this change, LLDB returned, in a way, the first "global" value it found with name "ScNSpacGl". I put "global" in quotes because, the variables in question here are in different semantic scopes, but physically have a "global" layout in memory. So, if we had done this:

  (lldb) p ScNSpacGl

before this change, LLDB would have printed the value of the global var not that of in the namespace. Now it prints the value of the one in the namespace.


Users:
  paulherman (Author)
  dawn (Auditor)

http://reviews.llvm.org/rL247746