[Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

[Kirill Lapshin via lldb-commits]

KLapshin marked an inline comment as done.
KLapshin added a comment.

In http://reviews.llvm.org/D12977#255390, @ki.stfu wrote:

> lgtm apart a lack of description about the changes in tools/lldb-mi/MICmdCmdSupportList.cpp


I added description about changes in list-features cmd handler in review summary. In source two comments present already.


================
Comment at: tools/lldb-mi/MICmdCmdExec.h:64
@@ -62,3 +63,3 @@
   private:
-    lldb::SBCommandReturnObject m_lldbResult;
+    const CMIUtilString m_constStrArgStart; // StopAtEntry - run to first instruction or main(), just run process if not specified
 };
----------------
Yes, @abidh added process start via Target Launch() method instead of "CLI" process command on 14 Aug 2014. But he forgot to remove m_lldbResult member usage (checking for error string has non-zero size) in Acknowledge() method. I removed this member usage finally.

BTW - as ExecRun is sync only command by its meaning (process started or not), Acknowledge() method called only if Execute() method reported successful status on completion, so we can skip any Process creation checks in Acknowledge(), thus m_lldbResult really not needed.


Repository:
  rL LLVM

http://reviews.llvm.org/D12977