[Lldb-commits] [PATCH] D13162: Change oat symbolization code for android to work on non-rooted devices

[Tamas Berghammer via lldb-commits]

tberghammer marked 3 inline comments as done.

================
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:340
@@ -346,1 +339,3 @@
         [this](std::string* s) {
+            AdbClient adb(m_device_id);
+
----------------
ovyalov wrote:
> Could you reuse adb variable defined before - e.g., wrap with shared_ptr? 
Fixed with capturing adb from the parent scope by reference. The destructor of the unique_ptr will be called earlier then the destructor of the AdbClient so no need for a shared_ptr


http://reviews.llvm.org/D13162