[Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

[Todd Fiala via lldb-commits]

tfiala added inline comments.

================
Comment at: test/test_runner/lib/process_control.py:552
@@ +551,3 @@
+                # We don't have anything else to try.
+                terminated = self.process.returncode is not None
+                done_trying = True
----------------
Drats, this should be self.returncode.  I'll be adjusting that.  Not germaine for your case, Zachary.

================
Comment at: test/test_runner/lib/process_control.py:562
@@ +561,3 @@
+                # We don't have anything else to try.
+                terminated = self.process.returncode is not None
+                done_trying = True
----------------
Same as above.  Should be testing against self.returncode.  I saw a few times where this value returned differently across calls.  (i.e. started as -{signal-number} after the first wait() call after its death, then called it again in a print statement a few lines later and it returned 0).  This would hit that same issue.

Granted this code block shouldn't ever get hit, since we don't ever try again after a hard kill attempt.


http://reviews.llvm.org/D13124