[Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 28 15:32:31 PDT 2015


tfiala added a comment.



> If it weren't for the fact that we have all these switches on `os.name`, `sys.platform`, and `platform.system` inside the tests as well as the test running infrastructure, then hiding it would be good.  But yea, the test suite itself is still really fragile due to all the conditionals, so it would be great to be able to use this cross platform helpers from anywhere in the test suite.  Making it a package sounds good, but I dont' think it needs to be done as part of this CL (or even immediately after) unless you really want to.


Good - I'll hold off on that part until later.


http://reviews.llvm.org/D13124





More information about the lldb-commits mailing list