[Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

[Todd Fiala via lldb-commits]

tfiala added a comment.

In http://reviews.llvm.org/D13124#255142, @zturner wrote:

> In http://reviews.llvm.org/D13124#255140, @tfiala wrote:
>
> > In http://reviews.llvm.org/D13124#255058, @zturner wrote:
> >
> > > Random thought: If you want to generate a core dump, we already have LLDB
> > >  attached to the process, so you have an SBProcess.  Couldn't you use
> > >  Process.Halt, then call whatever method is necessary to have the debugger
> > >  create a core, then Process.Kill?
> >
> >
> > I'm not sure I follow.  Here's the process layout:
> >
> > 1. dotest.py parallel runner -> 2. worker thread/process -> 3. dotest.py inferior process -> 4. optional inferior test subject used by the lldb test
> >
> >   Item 3 above is the process that needs to be killed and possibly core dumped.  It happens to be a process that may have an optional inferior (item #4) being tested by the lldb test code running in #3.  But we're trying to kill 3, and all of its children, and have 3 core dump.  (We don't care about a core dump for #4).
> >
> >   If we wanted to get a core for #4, that would seem possibly useful, but that's not the core we're looking for.
> >
> >   Did I follow your idea right?
>
>
> Ahh ok I thought it was a core of the inferior.  My bad.  Anyway that doesn't change anything about what I said earlier about not needing the soft terminate logic on Windows :)


Okay!


http://reviews.llvm.org/D13124