[Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

[Todd Fiala via lldb-commits]

tfiala added a comment.

In http://reviews.llvm.org/D13124#255044, @zturner wrote:

> Yea, on Windows we can support core dump generation externally without
>  touching the python script, so that's not neded for us.


Okay, good!

> Ironically, at the system level there is a way to specify the return code

>  of the process when you terminate it.  And Python internally must be using

>  this API, because it's the only way to do it.


Hah, that's interesting.

> They just decided not to

>  expose that parameter through the subprocess.terminate() method, and

>  instead they pass their own magic value.  If someone is clever enough to

>  dig through python source code and figure out what value it uses, we could

>  use that.  But I think on Windows it's safe to assume that if you call

>  process.terminate(), then it was a hard terminate, and we can ignore

>  everything else.

> 

> Does that make sense / is easy to do?


Yes, makes sense and yes I can accommodate by just making that soft terminate level optional by platform.  I'll get to working on that after lunch and I hope to have a patch up way before I head home today.


http://reviews.llvm.org/D13124