[Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

[Zachary Turner via lldb-commits]

As far as I can tell, the value of the return code is undocumented when you
use Popen.terminate() on Windows.  I don't know what that means for the
patch.  It's quite a bit more complicated than I anticipated based on the
original thread to lldb-dev.  I thought it was just going to call
Popen.terminate and assume that means it was a hard terminate.  I still
don't grasp the need for all the complexity.

A few experiments on a throwaway program suggest that using
Popen.terminate() sets returncode to 1, but there doesn't seem to be any
guarantee that this is always the case.

On Mon, Sep 28, 2015 at 11:53 AM Todd Fiala <todd.fiala at gmail.com> wrote:

> tfiala added a comment.
>
> The "was_soft_terminate()" method is looking at the subprocess.Popen-like
> object's returncode and, judging by that, certifying that it was (or was
> not) a soft terminate that caused the exit.
>
> If you need the Popen-like object to figure that out (e.g. if you need to
> look at some of the Windows-extended Popen attributes), we can rearrange
> this to take the Popen-like object rather than only its returncode.  That
> would be totally fine.
>
>
> http://reviews.llvm.org/D13124
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150928/01e91315/attachment.html>