[Lldb-commits] [PATCH] D12994: Improve support of the ncurses dependency on NetBSD

[Kamil Rytarowski via lldb-commits]

krytarowski added inline comments.

================
Comment at: include/lldb/Config/config.h.cmake:6
@@ +5,3 @@
+#else
+#define CONFIG_H
+
----------------
brucem wrote:
> brucem wrote:
> > This should be `LLDB_CONFIG_CONFIG_H` rather than just `CONFIG_H`.
> > 
> > Also, why not use the same `#ifndef` technique that everything else uses in the header files?
> Also, other headers in LLDB tend to have capitalized names, so maybe this should be `include/lldb/Config/Config.h.cmake`.
I was following the clang/llvm approach of exclusing llvm's config.h and subprojects' one.


Repository:
  rL LLVM

http://reviews.llvm.org/D12994