[Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 25 18:30:53 PDT 2015

tfiala added inline comments.

Comment at: test/dosep.py:245
@@ +244,3 @@
+        # binary should have called the results-generation code.
+        raise Exception("no test results were generated whatsoever")
+    return process_driver.results
This message should include the filename.

Comment at: test/process_control.py:273
@@ +272,3 @@
+    def create_piped_process(self, command, new_process_group=True):
+        if new_process_group:
This will want to store the popen_process.using_process_groups property like I do on the Posix side if the terminate would do something different based on the presence or absence of using process groups.  Oversight for not storing.


More information about the lldb-commits mailing list