[Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

[Ilia K via lldb-commits]

ki.stfu added inline comments.

================
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:191-193
@@ -182,1 +190,5 @@
 {
+    CMIUtilString summary;
+    if (TryGetValueSummary(summary))
+        return summary;
+
----------------
evgeny777 wrote:
> ki.stfu wrote:
> > ```
> > const CMIUtilString summary = GetValueSummary();
> > if (!summary.empty())
> >     return summary;
> > ```
> const CMIUtilString**&** summary = GetValueSummary();  ???
Yes, it's ok.

================
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.h:58
@@ -57,3 +57,3 @@
     bool GetCompositeValue(const bool vbPrintFieldNames, CMICmnMIValueTuple &vwrMiValueTuple, const MIuint vnDepth = 1) const;
-
+    bool TryGetValueSummary(CMIUtilString &vrValue) const;
     // Statics:
----------------
evgeny777 wrote:
> ki.stfu wrote:
> > It is better:
> > ```
> > CMIUtilString GetValueSummary(CMIUtilString &vrValue) const
> > ```
> Really?
> 
> Did you mean
> const  CMIUtilString& GetValueSummary(void) const ?
> 
> 
> 
Sorry, I mistyped.
```
CMIUtilString GetValueSummary() const
```


http://reviews.llvm.org/D13058