[Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

Eugene Leviant via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 25 00:49:20 PDT 2015


evgeny777 added inline comments.

================
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.h:58
@@ -57,3 +57,3 @@
     bool GetCompositeValue(const bool vbPrintFieldNames, CMICmnMIValueTuple &vwrMiValueTuple, const MIuint vnDepth = 1) const;
-
+    bool TryGetValueSummary(CMIUtilString &vrValue) const;
     // Statics:
----------------
ki.stfu wrote:
> It is better:
> ```
> CMIUtilString GetValueSummary(CMIUtilString &vrValue) const
> ```
Really?

Did you mean
const  CMIUtilString& GetValueSummary(void) const ?





http://reviews.llvm.org/D13058





More information about the lldb-commits mailing list