[Lldb-commits] [lldb] r248397 - test framework: fixed issue when using results formatter with no formatter options

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 23 10:20:10 PDT 2015


Author: tfiala
Date: Wed Sep 23 12:20:09 2015
New Revision: 248397

URL: http://llvm.org/viewvc/llvm-project?rev=248397&view=rev
Log:
test framework: fixed issue when using results formatter with no formatter options

I broke the formatter options-passing parsing when no formatter
options are provided.

Modified:
    lldb/trunk/test/dotest.py

Modified: lldb/trunk/test/dotest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/dotest.py?rev=248397&r1=248396&r2=248397&view=diff
==============================================================================
--- lldb/trunk/test/dotest.py (original)
+++ lldb/trunk/test/dotest.py Wed Sep 23 12:20:09 2015
@@ -1000,10 +1000,12 @@ def setupTestResults():
         # Handle formatter options for the results formatter class.
         formatter_arg_parser = clazz.arg_parser()
         if results_formatter_options and len(results_formatter_options) > 0:
-            formatter_options = formatter_arg_parser.parse_args(
-                results_formatter_options)
+            command_line_options = results_formatter_options
         else:
-            formatter_options = []
+            command_line_options = []
+
+        formatter_options = formatter_arg_parser.parse_args(
+            command_line_options)
 
         # Create the TestResultsFormatter given the processed options.
         results_formatter_object = clazz(results_file_object, formatter_options)




More information about the lldb-commits mailing list