[Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

Enrico Granata via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 22 11:16:25 PDT 2015

granata.enrico added a subscriber: granata.enrico.
granata.enrico requested changes to this revision.
granata.enrico added a reviewer: granata.enrico.
granata.enrico added a comment.

Is there a reason to explicitly add an API to get the concatenation of value and summary?

We already have APIs to retrieve the pieces:

  const char *
  GetValue ();
  const char *
  GetSummary ();

We even already have an API to retrieve the summary in an SBStream:

  const char *
  GetSummary (lldb::SBStream& stream,
              lldb::SBTypeSummaryOptions& options);

Is there a reason why the MI can't just call these APIs and then process the results as it sees fit?


More information about the lldb-commits mailing list