[Lldb-commits] [lldb] r248274 - RenderScript lookup bug fix

[Ewan Crawford via lldb-commits]

Author: ewancrawford
Date: Tue Sep 22 08:36:35 2015
New Revision: 248274

URL: http://llvm.org/viewvc/llvm-project?rev=248274&view=rev
Log:
RenderScript lookup bug fix

After the std::move operation the unique pointer is null. 
So this statement always returns a null pointer. 

Also remove unnecessary call to Module::ParseAllDebugSymbols(), 
which spews errors due to how it incorrectly tries to parse DWARF DIE types.

Modified:
    lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp

Modified: lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp?rev=248274&r1=248273&r2=248274&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp (original)
+++ lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp Tue Sep 22 08:36:35 2015
@@ -1225,7 +1225,7 @@ RenderScriptRuntime::LookUpScript(addr_t
         std::unique_ptr<ScriptDetails> s(new ScriptDetails);
         s->script = address;
         m_scripts.push_back(std::move(s));
-        return s.get();
+        return m_scripts.back().get();
     }
     return nullptr;
 }
@@ -1244,7 +1244,7 @@ RenderScriptRuntime::LookUpAllocation(ad
         std::unique_ptr<AllocationDetails> a(new AllocationDetails);
         a->address = address;
         m_allocations.push_back(std::move(a));
-        return a.get();
+        return m_allocations.back().get();
     }
     return nullptr;
 }
@@ -1254,7 +1254,6 @@ RSModuleDescriptor::Dump(Stream &strm) c
 {
     strm.Indent();
     m_module->GetFileSpec().Dump(&strm);
-    m_module->ParseAllDebugSymbols();
     if(m_module->GetNumCompileUnits())
     {
         strm.Indent("Debug info loaded.");