[Lldb-commits] [PATCH] D13028: [RFC] Merge dsym and dwarf test cases

[Tamas Berghammer via lldb-commits]

tberghammer created this revision.
tberghammer added reviewers: labath, clayborg, emaste, tfiala, zturner.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.

[RFC] Merge dsym and dwarf test cases

Currently most of the test files have a separate dwarf and a separate dsym test with almost identical content (only the build step is different). With adding dwo symbol file handling to the test suit it would increase this to a 3-way duplication. The purpose of this change is to eliminate this redundancy with generating 2 test case (one dwarf and one dsym) for each test function specified (dwo handling will be added at a later commit).

Main design goals:
* There should be no boilerplate code in each test file to support the multiple debug info in most of the tests (custom scenarios are acceptable in special cases) so adding a new test case is easier and we can't miss one of the debug info type
* In case of a test failure, the debug symbols used during the test run have to be cleanly visible from the output of dotest.py to make debugging easier both from build bot logs and from local test runs
* Each test case should have a unique, fully qualified name so we can run exactly 1 test with "-f <test-case>.<test-function>" syntax
* Test output should be grouped based on test files the same way as it happens now (displaying dwarf/dsym results separately isn't preferable)

Proposed solution (main logic in lldbtest.py, rest of them are test cases fixed up for the new style):
* Have only 1 test fuction in the test files what will run for all debug info separately and this test function should call just "self.build(...)" to build an inferior with the right debug info
* When a class is created by python (the class object, not the class instance), we will generate a new test method for each debug info format in the test class with the name "<test-function>_<debug-info>" and remove the original test method. This way unittest2 see multiple test methods (1 for each debug info, pretty much as of now) and will handle the test selection and the failure reporting correctly (the debug info will be visible from the end of the test name)
* Add new annotation @no_debug_info_test to disable the generation of multiple tests for each debug info format when the test don't have an inferior

The current version of the CL is a proof of concept with the main test generation code is in place (in lldbtest.py) and some of the tests are migrated to the new schema as examples. I would like to ask for general feedback about the approach and if people are happy with this direction then I will move all tests over to this format and then commit in this change after a second review pass (partial movement isn't feasible).

http://reviews.llvm.org/D13028

Files:
  test/arm_emulation/TestEmulations.py
  test/benchmarks/continue/TestBenchmarkContinue.py
  test/benchmarks/disassembly/TestDisassembly.py
  test/benchmarks/disassembly/TestDoAttachThenDisassembly.py
  test/benchmarks/disassembly/TestXcode41Vs42GDBDisassembly.py
  test/benchmarks/expression/TestExpressionCmd.py
  test/benchmarks/expression/TestRepeatedExprs.py
  test/benchmarks/frame_variable/TestFrameVariableResponse.py
  test/benchmarks/startup/TestStartupDelays.py
  test/benchmarks/stepping/TestRunHooksThenSteppings.py
  test/benchmarks/stepping/TestSteppingSpeed.py
  test/benchmarks/turnaround/TestCompileRunToBreakpointTurnaround.py
  test/driver/batch_mode/TestBatchMode.py
  test/expression_command/call-function/TestCallStdStringFunction.py
  test/expression_command/call-function/TestCallStopAndContinue.py
  test/expression_command/call-function/TestCallUserDefinedFunction.py
  test/expression_command/call-restarts/TestCallThatRestarts.py
  test/expression_command/call-throws/TestCallThatThrows.py
  test/expression_command/expr-in-syscall/TestExpressionInSyscall.py
  test/expression_command/formatters/TestFormatters.py
  test/expression_command/issue_11588/Test11588.py
  test/expression_command/options/TestExprOptions.py
  test/expression_command/persist_objc_pointeetype/TestPersistObjCPointeeType.py
  test/expression_command/persistent_ptr_update/TestPersistentPtrUpdate.py
  test/expression_command/persistent_types/TestNestedPersistentTypes.py
  test/expression_command/persistent_types/TestPersistentTypes.py
  test/expression_command/persistent_variables/TestPersistentVariables.py
  test/expression_command/po_verbosity/TestPoVerbosity.py
  test/expression_command/radar_8638051/Test8638051.py
  test/expression_command/radar_9531204/TestPrintfAfterUp.py
  test/expression_command/radar_9673664/TestExprHelpExamples.py
  test/expression_command/test/TestExprs.py
  test/expression_command/timeout/TestCallWithTimeout.py
  test/expression_command/two-files/TestObjCTypeQueryFromOtherCompileUnit.py
  test/functionalities/abbreviation/TestAbbreviations.py
  test/functionalities/abbreviation/TestCommonShortSpellings.py
  test/functionalities/archives/TestBSDArchives.py
  test/functionalities/asan/TestMemoryHistory.py
  test/functionalities/asan/TestReportData.py
  test/functionalities/attach_resume/TestAttachResume.py
  test/functionalities/avoids-fd-leak/TestFdLeak.py
  test/functionalities/backticks/TestBackticksWithoutATarget.py
  test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
  test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommandsFromPython.py
  test/functionalities/breakpoint/breakpoint_command/TestRegexpBreakCommand.py
  test/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py
  test/functionalities/breakpoint/breakpoint_ids/TestBreakpointIDs.py
  test/functionalities/breakpoint/breakpoint_ignore_count/TestBreakpointIgnoreCount.py
  test/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py
  test/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
  test/functionalities/breakpoint/comp_dir_symlink/TestCompDirSymLink.py
  test/functionalities/breakpoint/consecutive_breakpoins/TestConsecutiveBreakpoints.py
  test/functionalities/breakpoint/cpp/TestCPPBreakpointLocations.py
  test/functionalities/breakpoint/cpp_exception/TestCPPExceptionBreakpoint.py
  test/functionalities/breakpoint/dummy_target_breakpoints/TestBreakpointsWithNoTargets.py
  test/functionalities/breakpoint/inlined_breakpoints/TestInlinedBreakpoints.py
  test/functionalities/breakpoint/objc/TestObjCBreakpoints.py
  test/functionalities/command_history/TestCommandHistory.py
  test/functionalities/command_regex/TestCommandRegex.py
  test/functionalities/command_script/TestCommandScript.py
  test/functionalities/command_script/import/TestImport.py
  test/functionalities/command_script/import/rdar-12586188/TestRdar12586188.py
  test/functionalities/command_source/TestCommandSource.py
  test/functionalities/completion/TestCompletion.py
  test/functionalities/conditional_break/TestConditionalBreak.py
  test/functionalities/connect_remote/TestConnectRemote.py
  test/lldbtest.py
  test/types/AbstractBase.py
  test/types/TestFloatTypes.py
  test/types/TestFloatTypesExpr.py
  test/types/TestIntegerTypes.py
  test/types/TestIntegerTypesExpr.py
  test/types/TestRecursiveTypes.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13028.35287.patch
Type: text/x-patch
Size: 105802 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150921/d5ec7c51/attachment-0001.bin>