[Lldb-commits] [PATCH] D13022: Use fcntl.h to retrieve the O_CREAT and O_RDRW constants.

Vasileios Kalintiris via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 21 08:07:46 PDT 2015

vkalintiris added a comment.

In http://reviews.llvm.org/D13022#249823, @emaste wrote:

> Although it ought to remain on the same line, no?

It shouldn't matter in this case. I just followed the order of the headers in the synopsis section of shm_open(3) on my system.
However, I noticed that we should use fcntl.h instead of sys/fcntl.h. The former is POSIX-compatible while the latter (based on my understanding) is being used to expose additional kernel-defines in some systems. Does this look good to you?


More information about the lldb-commits mailing list